add deprecation pragmas #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
force-pushed
the
deprecation-notices
branch
from
046d140 to
7a50ce8
Compare
This was referenced Jun 14, 2016
Closed
|
Sorry but I don't catch up this issue. |
|
@kazu-yamamoto, these aliases have been deprecated for a while, but have never received a proper pragma. Frankly I don't prefer either name over the other, but momentum is behind those not documented as deprecated and I prefer one name instead of two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI looks good, can be merged after review. This paves the way for pull request #190, which I will bring up to date soon.