WIP: Drop possibly gratuitous Typeable instances

Does anyone know why they are needed?
haskell · May 23, 2020 · 2ac0cc0 · 2ac0cc0
1 parent 46d2996
commit 2ac0cc0
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/Network/Socket/Imports.hs b/Network/Socket/Imports.hs
@@ -7,7 +7,6 @@ module Network.Socket.Imports (
   , module Data.Maybe
   , module Data.Monoid
   , module Data.Ord
-  , module Data.Typeable
   , module Data.Word
   , module Foreign.C.String
   , module Foreign.C.Types
@@ -24,7 +23,6 @@ import Data.List
 import Data.Maybe
 import Data.Monoid
 import Data.Ord
-import Data.Typeable
 import Data.Word
 import Foreign.C.String
 import Foreign.C.Types

diff --git a/Network/Socket/Info.hsc b/Network/Socket/Info.hsc
@@ -1,5 +1,4 @@
 {-# LANGUAGE CPP #-}
-{-# LANGUAGE DeriveDataTypeable #-}
 {-# LANGUAGE RecordWildCards #-}
 {-# OPTIONS_GHC -fno-warn-orphans #-}
 
@@ -63,7 +62,7 @@ data AddrInfoFlag =
     --   addresses are found, IPv6-mapped IPv4 addresses will be
     --   returned. (Only some platforms support this.)
     | AI_V4MAPPED
-    deriving (Eq, Read, Show, Typeable)
+    deriving (Eq, Read, Show)
 
 aiFlagMapping :: [(AddrInfoFlag, CInt)]
 
@@ -106,7 +105,7 @@ data AddrInfo = AddrInfo {
   , addrProtocol :: ProtocolNumber
   , addrAddress :: SockAddr
   , addrCanonName :: Maybe String
-  } deriving (Eq, Show, Typeable)
+  } deriving (Eq, Show)
 
 instance Storable AddrInfo where
     sizeOf    _ = #const sizeof(struct addrinfo)
@@ -170,7 +169,7 @@ data NameInfoFlag =
     --   looked up.  Instead, a numeric representation of the
     --   service is returned.
     | NI_NUMERICSERV
-    deriving (Eq, Read, Show, Typeable)
+    deriving (Eq, Read, Show)
 
 niFlagMapping :: [(NameInfoFlag, CInt)]
 

diff --git a/Network/Socket/Options.hsc b/Network/Socket/Options.hsc
@@ -1,5 +1,4 @@
 {-# LANGUAGE CPP #-}
-{-# LANGUAGE DeriveDataTypeable #-}
 {-# LANGUAGE PatternSynonyms #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE ViewPatterns #-}

diff --git a/Network/Socket/Shutdown.hs b/Network/Socket/Shutdown.hs
@@ -1,5 +1,4 @@
 {-# LANGUAGE CPP #-}
-{-# LANGUAGE DeriveDataTypeable #-}
 
 #include "HsNetDef.h"
 
@@ -27,7 +26,6 @@ import Network.Socket.Types
 data ShutdownCmd = ShutdownReceive
                  | ShutdownSend
                  | ShutdownBoth
-                 deriving Typeable
 
 sdownCmdToInt :: ShutdownCmd -> CInt
 sdownCmdToInt ShutdownReceive = 0