Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Add an instance for the new SeedGen type class #98

Merged

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jan 7, 2025

This is a slower, but more accurate alternative to #96

As mentioned in #96 this approach handles endianness correctly

@lehins lehins marked this pull request as ready for review January 7, 2025 19:48
@lehins lehins force-pushed the lehins/add-random-seed-instance-alternative branch from 2e15430 to 13c61bc Compare January 7, 2025 19:49
@Shimuuar
Copy link
Collaborator

Lets go with this one. Mostly because it have less conditional compilation. Having support for both random 1.2 and 1.3 is painful enough. I don't want to support different versions of primitive as well

@Shimuuar
Copy link
Collaborator

I also played a with optimizing your implementation. It turns out -O2 has pretty big effect. With -O1 inner loops produced by stream fusion pass around tuples of int etc. I'll check whether it has any effect on rest of library and make release then

@Shimuuar Shimuuar merged commit c134e61 into haskell:master Jan 11, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants