activate-hs does not handle all errors

[brson]

Several file-system modifying commands in this script are not checked for errors. See for example the symlink functions. It looks to me like, if these fail, the script will simply continue (possibly with the failing command itself printing an error message to stderr).

This may be an intentional 'best-effort' strategy, but I would expect the script to detect and report the errors, or possibly be run with set -e to automatically abort, or even better, have some recovery strategy to not leave the install in a broken state.

[mzero]

I've added the set -e to the script, and pushed to pre-release branch.
If your bash scripting skills are better than mine (not hard!) then I'd be happy for a patch that did more!
If not, would prefer we just resolve this or put it on the back burner?