Add case for haskell-debug-parse-module regex to parse #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get some tests with this change?
|
|
@gracjan Sure, no problem. I couldn't find where tests go though. I also did see anything about tests in CONTRIBUTING.md. |
|
Create a new test file called tests/haskell-debug-tests.el. |
gracjan
added a commit
that referenced
this pull request
Nov 25, 2015
Add case for haskell-debug-parse-module regex to parse
|
I see that this is better than it used to be, but still quite wrong: no national letters, no other character legal in file names, no spaces. I guess we will revisit when somebody actually hits the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried debugging a simple Haskell program in haskell-mode from spacemacs and got an error from this regex not matching. This change makes it work.