Clean up SCC code #986
Merged
Clean up SCC code #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If point is on the second character of a word, haskell-mode-try-scc-at-point will break the word, inserting an SCC annotation between the first and second characters.
Don't insert SCC if the character before point is the beginning of a
word. Do insert SCC if the character at point is not the beginning of a
word, but the character before point is whitespace. This occurs when
the character at point is a non-letter, such as = or {.
|
This is really good! Please use |
|
Thanks for pointing out |
|
Ah, whoops, I didn't realize the third argument to |
|
We will see if there is anybody bitching about |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion at #961, I've tried to make the SCC functions (which I use) more pleasant to use and to maintain. Please let me know if you want things done differently.
I wrote a new function to toggle SCC's, so only one keybinding is necessary. I refactored the existing code to avoid spurious errors about "can't remove SCC" when adding an SCC. I kept the old functions around for backwards compatibility, but I don't really care if they go away.
Along the way I found a bug, which I think I've fixed and adequately described in the commit messages.