Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove haskell-checkers.el #959

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Remove haskell-checkers.el #959

merged 1 commit into from
Aug 18, 2016

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Oct 26, 2015

haskell-checkers used to provide:

  • 'scan' interface (limited), as far as we know nobody is using that
  • 'hlint' interface, superseeded by much better flycheck-hlint in flycheck project

@ivan-m
Copy link
Contributor

ivan-m commented Oct 27, 2015

I don't know about "much better": I still tend to prefer the hs-lint package that's shipped with hlint as it can update the errors for you (which I don't think flycheck can do); I see that haskell-checkers also has support for doing this kind of update.

@gracjan
Copy link
Contributor Author

gracjan commented Oct 27, 2015

I guess nobody knew that haskell-checkers has this functionality (only for hlint). Haskell Mode should strive to provide Complete functionality.

Flycheck is moving in the direction described in flycheck/flycheck#530.

Proposition:

  • you keep using the external package for now
  • community helps flycheck to provide the functionality

I do not think we can afford keeping unused haskell-checkers around knowing that there are better options cooking elsewhere.

@ivan-m
Copy link
Contributor

ivan-m commented Oct 27, 2015

I did a quick search on GitHub, and it seems that those people who - like myself - require haskell-checkers aren't using it (I think the template .emacs setup for haskell-mode had it at one stage even though it wasn't used, so a few of us copy-pasted it in).

Possibly document the option of getting hs-lint more clearly for people who might want that functionality, especially since it seems flycheck won't be getting it any time soon.

@bbatsov
Copy link
Contributor

bbatsov commented Jan 25, 2016

Removing this makes sense.

@gracjan gracjan merged commit 268a598 into haskell:master Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants