Implement haskell-goto-first-error #1100
Conversation
|
|
||
| (defun insert-errors () | ||
| (insert "import Control.Applicativ\nimport Data.Mayb\nimport Data.String") | ||
| (let ((a (make-overlay 18 36)) |
There was a problem hiding this comment.
Please use re-search-forward and then (match-begin 0) and (match-end 0) to put the overlays. Should somebody come and need to change these tests they will be intimidated by character counting and won't do it.
|
Very nice! Please get rid of those hardcoded numbers and then we are good to merge. |
bergey
force-pushed
the
pr-haskell-goto-first-error
branch
from
a4ee9aa
to
6af7880
Compare
|
@gracjan I force pushed the changes you requested. |
| (require 'haskell-load) | ||
|
|
||
| (defun insert-errors () | ||
| (insert "import Control.Applicativ\nimport Data.Mayb\nimport Data.String") |
There was a problem hiding this comment.
One more nitpick: Can I have one space here between import and module names?
Counting spaces might be intimidating for future developers, too.
- haskell-goto-next-error - haskell-goto-prev-error - haskell-goto-first-error
bergey
force-pushed
the
pr-haskell-goto-first-error
branch
from
6af7880
to
788a70c
Compare
|
Makes sense. I started from real Haskell code, and the extra spaces are what |
gracjan
changed the title
Implement haskell-goto-first-error
|
Perfect, thanks. |
Supercedes #818