Make vscode-extension-schema honour default values #3925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3917, where the command
hls vscode-extension-schema
did not to honour the default values of the plugin description.The first commit of this PR fixes that shortcoming.
The second commit unifies the plugin config generation. I am not sure whether that's a good idea, as I feel it obfuscates the code more. I am leaving it in for discussion, but I am completely open to dropping the second commit.