-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds :kind
and :kind!
commands to Eval Plugin
#345
Conversation
:kind
and :kind!
commands to Eval Plugin:kind
and :kind!
commands to Eval Plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
import Data.Proxy | ||
import Data.Proxy (Proxy(..)) | ||
|
||
type P = Proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you let me know why have you changed this test? It seems irrelevant to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that change is not directly related to my change; but without this hack, at least on my laptop, Applies file LANGUAGE extensions
test case fails due to the interference with import lens.
This issue seems already existent in the master
branch and I wanted to avoid such errors to make my pull-request get merged as soon as possible. Indeed, I once wondered if I should make this change in this pull-request but I decided to include it since it's a minor change and somewhat related to Eval
plugin.
But, yes, this change is semantically separate from this pull-request. Should I file this workaround as another pull-request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worthwhile to post that as an issue, but for the separated PR, it's OK to stay this change as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice!
What does block this to be merged? |
Thanks! |
* Implements `:kind!` GHCi command to Eval plugin * Adds golden tests for `:kind!` * Removes redundant lines * Adds `:kind` command that returns kind only without normalisation * Test cases for `:kind` * Fixes `Applies file LANGUAGE extensions` to avoid sufferring from ImportLens * Removes redundant leading space
This pull request implements
:kind
and:kind!
commands ala GHCi to Eval plugin.The former displays the kind of a given type and the latter also displays the normalised form of a given type.
Examples
evaluates to:
And
evaluates to: