Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump partial ghc support warning to 9.4 #3286

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Bump partial ghc support warning to 9.4 #3286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ghcide/src/Development/IDE/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ data Log
| LogLspStart [PluginId]
| LogLspStartDuration !Seconds
| LogShouldRunSubset !Bool
| LogOnlyPartialGhc92Support
| LogOnlyPartialGhc94Support
| LogSetInitialDynFlagsException !SomeException
| LogService Service.Log
| LogShake Shake.Log
Expand All @@ -173,8 +173,8 @@ instance Pretty Log where
"Started LSP server in" <+> pretty (showDuration duration)
LogShouldRunSubset shouldRunSubset ->
"shouldRunSubset:" <+> pretty shouldRunSubset
LogOnlyPartialGhc92Support ->
"Currently, HLS supports GHC 9.2 only partially. See [issue #2982](https://github.com/haskell/haskell-language-server/issues/2982) for more detail."
LogOnlyPartialGhc94Support ->
"Currently, HLS supports GHC 9.4 only partially. See [issue #3190](https://github.com/haskell/haskell-language-server/issues/3190) for more detail."
LogSetInitialDynFlagsException e ->
"setInitialDynFlags:" <+> pretty (displayException e)
LogService log -> pretty log
Expand Down Expand Up @@ -353,9 +353,9 @@ defaultMain recorder Arguments{..} = withHeapStats (cmapWithPrio LogHeapStats re
, optRunSubset = runSubset
}
caps = LSP.resClientCapabilities env
-- FIXME: Remove this after GHC 9.2 gets fully supported
when (ghcVersion == GHC92) $
log Warning LogOnlyPartialGhc92Support
-- FIXME: Remove this after GHC 9.4 gets fully supported
when (ghcVersion == GHC94) $
log Warning LogOnlyPartialGhc94Support
monitoring <- argsMonitoring
initialise
(cmapWithPrio LogService recorder)
Expand Down