lock-less Values state #2429
Merged
lock-less Values state #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Dec 2, 2021
pepeiborra
force-pushed
the
lockless-values
branch
from
155d641 to
3effdd4
Compare
michaelpj
reviewed
Dec 3, 2021
| deleteValue ShakeExtras{dirtyKeys, state} key file = do | ||
| void $ modifyVar' state $ HMap.delete (toKey key file) | ||
| atomicModifyIORef_ dirtyKeys $ HSet.insert (toKey key file) | ||
| deleteValue ShakeExtras{dirtyKeys, state} key file = atomically $ do |
There was a problem hiding this comment.
this one should maybe have got pushed to the call sites too? particularly paralleling setValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third extract from #2357. This change removes the locking around the build cache by replacing it with an STM Map