Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in completions #1265

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix a bug in completions #1265

merged 2 commits into from
Jan 27, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Jan 26, 2021 •
edited
Loading

The bug, introduced in #1256, was preventing completions from refreshing on input

BEFORE

before.mov

AFTER

after.mov

jneira
jneira approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Jan 26, 2021
@mergify mergify bot merged commit ff5438c into master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepeiborra @jneira @Ailrun