Skip to content

Commit

Permalink
Fix -Wall and -Wunused-packages in stan plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
jhrcek committed Feb 2, 2024
1 parent 5c11636 commit 9a526a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
6 changes: 0 additions & 6 deletions haskell-language-server.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -676,17 +676,13 @@ library hls-stan-plugin
hs-source-dirs: plugins/hls-stan-plugin/src
build-depends:
base
, containers
, data-default
, deepseq
, hashable
, hie-compat
, hls-plugin-api
, ghc
, ghcide
, lsp-types
, text
, transformers
, unordered-containers
, stan >= 0.1.2.0
, trial
Expand All @@ -711,9 +707,7 @@ test-suite hls-stan-plugin-tests
hs-source-dirs: plugins/hls-stan-plugin/test
main-is: Main.hs
build-depends:
aeson
, base
, containers
, filepath
, haskell-language-server:hls-stan-plugin
, hls-plugin-api
Expand Down
8 changes: 2 additions & 6 deletions plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ stripModifiers = go ""
Nothing -> txt
Just index -> T.drop (index + 1) txt

renderId :: Id a -> T.Text
renderId (Id t) = "Id = " <> t

instance Pretty Log where
pretty = \case
LogShake log -> pretty log
Expand Down Expand Up @@ -136,12 +133,11 @@ rules recorder plId = do
}

(configTrial, useDefConfig, env) <- liftIO $ getStanConfig stanArgs isLoud
seTomlFiles <- liftIO $ usedTomlFiles useDefConfig (stanArgsConfigFile stanArgs)
logWith recorder Debug (LogDebugStanConfigResult seTomlFiles configTrial)
tomlsUsedByStan <- liftIO $ usedTomlFiles useDefConfig (stanArgsConfigFile stanArgs)
logWith recorder Debug (LogDebugStanConfigResult tomlsUsedByStan configTrial)

-- If envVar is set to 'False', stan will ignore all local and global .stan.toml files
logWith recorder Debug (LogDebugStanEnvVars env)
seTomlFiles <- liftIO $ usedTomlFiles useDefConfig (stanArgsConfigFile stanArgs)

-- Note that Stan works in terms of relative paths, but the HIE come in as absolute. Without
-- making its path relative, the file name(s) won't line up with the associated Map keys.
Expand Down

0 comments on commit 9a526a5

Please sign in to comment.