Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Fix failing tests in windows (reloaded) #1655

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 14, 2020

  • Using a patched version of cabal-helper (until the next release)
    • It includes the remove of the private lib
  • Azure windows agent have changed their drives space now C: has lot of more space than D:, so i've switched again cache to C:
  • Some of unit failing tests had been fixed by Set current working directory when executing project ghc #1654

@jneira jneira requested a review from fendor February 14, 2020 22:08
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why no git submodules? That was previously how we handled modified packages

@jneira
Copy link
Member Author

jneira commented Feb 15, 2020

mmm, i've found submodules more suited to mid or long term forks due to the additional effort to setup and maintain them, i hope this is a provisional workaround

@jneira jneira merged commit 66163e0 into haskell:master Feb 16, 2020
@jneira jneira deleted the azure-fix-win branch February 16, 2020 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants