Improve Windows support #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On legacy operating systems, lines in text files in the working tree might be CR or CRLF separated instead of being LF terminated. The .gitattributes file instructs Git on legacy systems to transform such text files into LF text files when reading them, preserving text files as LF text files in the repository.
In addition to looking for preferences in a dotfile in ~, look for preferences in accordance with the XDG Base Directory Specification or in %APPDATA% in accordance with Windows NT convention. Note that on Windows, ~ is, surprisingly in the context of preferences, %USERPROFILE%, not %HOME% or %APPDATA%.
Data.Functor.(<&>) was introduced in base 4.11.0 (shipped with GHC in 2018 Q1). Copying the function definition allows haskeline to be built with base and GHC dating from 2016 Q1.
Aim: to simplify testing of error handling later on. Rationale: a happy case needed for backwards-compatibility and discoverability, namely reading preferences from ~/.haskeline, is also an error case, namely the case of $XDG_CONFIG_HOME/haskeline/preferences (or equivalent) being unreadable (e.g. nonexistent). IO actions are factored out of the error checking, which instead depend on [], Maybe, MonadPlus and MonadCatch.
readPrefs has hitherto, save for a few commits, and should continue to, read preferences from a given FilePath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for preferences in
$XDG_CONFIG_HOMEor%APPDATA%improves standards conformance. In addition to resulting in a more predictable preference file location on Windows NT, it enables tidier ~ directories on all platforms. Declaring the text files in this repository as using LF terminated lines improves the contribution experience on legacy operating systems such as DOS, Windows and classic (pre-Darwin) Mac OS.