Fix the Dockerfile so that it actually builds #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d user interaction Without that setting, the docker build fails to install postfix. See https://askubuntu.com/questions/556385/how-can-i-install-apt-packages-non-interactively for further details. Fixes haskell#835.
Older versions fail with:
cabal: ./hackage-server.cabal:347: Parse of field 'build-depends' failed.
This is necessary to avoid haskell/cabal#6125. Fixes haskell/cabal#6125 at last.
|
Ping? |
ocramz
approved these changes
Aug 5, 2019
|
@peti Thank you! |
|
hrm... I'm not happy with the Dockerfile as is, specifically the part where it builds from Git; But since this got merged already in the current state I'll have to follow-up with a commit to master later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835.
Supersedes: #826.