Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate more complete CI via haskell-ci #1061

Merged
merged 5 commits into from
Apr 16, 2022
Merged

Conversation

andreasabel
Copy link
Member

Atm. requires a patched version of haskell-ci

to include the "haddock" step.

For now, this PR replaces

which instead patched the workflow produced by haskell-ci.

Also:

  • fix missing extra-source-files: in .cabal file (detected by this CI (haskell-ci.yml) but not the previous one (ci.yml))
  • delete .travis.yml.

@andreasabel andreasabel added the re: CI Concerning continuous integration (CI) label Apr 16, 2022
@andreasabel
Copy link
Member Author

andreasabel commented Apr 16, 2022

The old CI can easily be restored by:

  • deleting .github/workflows/haskell-ci.yml
  • renaming .github/workflows/ci.yml.deactivated to .../ci.yml

However, the old CI likely handles the cache wrongly: #1059 (comment)

@jneira
Copy link
Member

jneira commented Apr 16, 2022

I see the point of using haskell-ci but you could got a workflow for the three or two main os's with the half of code, but I guess you already know it
Also dependabot could upgrade actions automatically

@andreasabel
Copy link
Member Author

andreasabel commented Apr 17, 2022

I see the point of using haskell-ci but you could got a workflow for the three or two main os's with the half of code, but I guess you already know it Also dependabot could upgrade actions automatically

Ah, actually I don't know. Do you have a pointer to a CI in that style, with some automatic upgrade mechanism?

P.S.: Haskell-CI is more strict than the one we had before. For instance, I missed some extra-source-files for tests, and Haskell-CI caught this, but not our previous CI.

@jneira
Copy link
Member

jneira commented Apr 17, 2022

Ah, actually I don't know. Do you have a pointer to a CI in that style, with some automatic upgrade mechanism?

dependabot opens prs to upgrade github actions, see haskell/haskell-language-server#2823 for example
you can do it with haskell-ci but the updated config would be overwritten by the next regeneration

that is the main drawback of code generators, they dont compose (or compose hardly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: CI Concerning continuous integration (CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants