Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pager support wrt #1118 #1119

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Implement pager support wrt #1118 #1119

merged 12 commits into from
Sep 24, 2024

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Aug 12, 2024

TODO:

  • document
  • config options should be pager, not pager-config (adjust json)
  • deal with windows

app/ghcup/Main.hs Outdated Show resolved Hide resolved
@hasufell
Copy link
Member Author

When using less... the unicode stuff doesn't work very well. You have to either export LESSCHARSET=utf-8 or use PAGER='less -r'.

lib/GHCup/Utils/Pager.hs Outdated Show resolved Hide resolved
lib/GHCup/Utils/Pager.hs Outdated Show resolved Hide resolved
@dfordivam
Copy link
Collaborator

For windows the more might work, will need testing i it work from within the process's invocation, writing to stdin (https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/more)

@hasufell
Copy link
Member Author

For windows the more might work, will need testing i it work from within the process's invocation, writing to stdin (https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/more)

in powershell, it does not... in msys2 anything works

@dfordivam
Copy link
Collaborator

When using less... the unicode stuff doesn't work very well. You have to either export LESSCHARSET=utf-8 or use PAGER='less -r'.

I had LESS=-R in my config and hence didn't notice this issue.

@dfordivam
Copy link
Collaborator

LGTM, the incremental improvements could be done later.

@hasufell hasufell force-pushed the pager branch 2 times, most recently from bc00739 to 5e90d53 Compare August 14, 2024 07:51
lib/GHCup/Utils/Pager.hs Outdated Show resolved Hide resolved
@hasufell hasufell merged commit d4cde3e into master Sep 24, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants