This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Rename hDuplicateTo to hDuplicateTo' #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some issues in GHCi on the DAML codebase where it complains
about:
<interactive>:28:1: error:
Ambiguous occurrence `hDuplicateTo'
It could refer to either `Development.IDE.GHC.Util.hDuplicateTo',
imported from `Development.IDE.GHC.Util' at compiler/damlc/daml-opts/daml-opts/DA/Daml/Options.hs:36:1-31
or `GHC.IO.Handle.hDuplicateTo', imported from `GHC.IO.Handle'
Given that this is only internal to ghcide anyway, we can just rename it.
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
We have some issues in GHCi on the DAML codebase where it complains
about:
<interactive>:28:1: error:
Ambiguous occurrence `hDuplicateTo'
It could refer to either `Development.IDE.GHC.Util.hDuplicateTo',
imported from `Development.IDE.GHC.Util' at compiler/damlc/daml-opts/daml-opts/DA/Daml/Options.hs:36:1-31
or `GHC.IO.Handle.hDuplicateTo', imported from `GHC.IO.Handle'
Given that this is only internal to ghcide anyway, we can just rename it.
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
We have some issues in GHCi on the DAML codebase where it complains
about:
<interactive>:28:1: error:
Ambiguous occurrence `hDuplicateTo'
It could refer to either `Development.IDE.GHC.Util.hDuplicateTo',
imported from `Development.IDE.GHC.Util' at compiler/damlc/daml-opts/daml-opts/DA/Daml/Options.hs:36:1-31
or `GHC.IO.Handle.hDuplicateTo', imported from `GHC.IO.Handle'
Given that this is only internal to ghcide anyway, we can just rename it.
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
We have some issues in GHCi on the DAML codebase where it complains
about:
<interactive>:28:1: error:
Ambiguous occurrence `hDuplicateTo'
It could refer to either `Development.IDE.GHC.Util.hDuplicateTo',
imported from `Development.IDE.GHC.Util' at compiler/damlc/daml-opts/daml-opts/DA/Daml/Options.hs:36:1-31
or `GHC.IO.Handle.hDuplicateTo', imported from `GHC.IO.Handle'
Given that this is only internal to ghcide anyway, we can just rename it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some issues in GHCi on the DAML codebase where it complains
about:
:28:1: error:
Ambiguous occurrence
hDuplicateTo' It could refer to eitherDevelopment.IDE.GHC.Util.hDuplicateTo',imported from
Development.IDE.GHC.Util' at compiler/damlc/daml-opts/daml-opts/DA/Daml/Options.hs:36:1-31 orGHC.IO.Handle.hDuplicateTo', imported from `GHC.IO.Handle'Given that this is only internal to ghcide anyway, we can just rename it.