Make sure to set ioe_filename in IOException #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #17 Also improves the property tests to examine more of the IOException.
hasufell
commented
Jan 13, 2024
| h <- openFile fp iomode | ||
| openBinaryFile osfp iomode = augmentError "openBinaryFile" osfp $ openBinaryFile' osfp iomode | ||
|
|
||
| openBinaryFile' :: OsPath -> IOMode -> IO Handle |
There was a problem hiding this comment.
Internal variant so that withFile doesn't accumulate two augmentError calls
hasufell
commented
Jan 13, 2024
| hClose | ||
| action | ||
| (try . action)) |
There was a problem hiding this comment.
This is the same as haskell/core-libraries-committee#237
hasufell
commented
Jan 13, 2024
|
|
||
| addFilePathToIOError :: String -> OsPath -> IOException -> IOException | ||
| addFilePathToIOError fun fp ioe = unsafePerformIO $ do | ||
| fp' <- either (const (fmap OSP.toChar . OSP.unpack $ fp)) id <$> try @SomeException (OSP.decodeFS fp) |
There was a problem hiding this comment.
This matches the logic in unix: https://github.com/haskell/unix/blob/7db23ecad7593210ce38c48a462be6c50d080e00/System/Posix/PosixPath/FilePath.hsc#L161
Except we're not in IO and so I use SomeException and try to force the result as best as possible.
hasufell
commented
Jan 13, 2024
'fdToHandle' is an abomination that corrupts the IOException fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.