-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 processor architecture support #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairB
changed the title
Testing with travis, to have ARM based CI
Trying to get some CI ARM thing going
Nov 28, 2021
Saving a record of what I used for the emulated approach before I squash. This failed because emulated:
timeout-minutes: 30
runs-on: ubuntu-latest
name: ${{ matrix.ghc }}-${{ matrix.deb }}
strategy:
fail-fast: false
matrix:
ghc: ['9.2.1']
deb: ['buster']
include:
# - ghc: '8.10.7'
# ghc_minor: '8.10'
# - ghc: '9.0.1'
# ghc_minor: '9.0'
- ghc: '9.2.1'
ghc_minor: '9.2'
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
repository: docker-library/official-images
path: official-images
- name: docker build [${{ matrix.ghc }}]
uses: uraimo/[email protected]
with:
arch: aarch64
distro: ${{ matrix.deb }}
githubToken: ${{ github.token }}
dockerRunArgs: |
--volume "${PWD}/official-images:/official-images"
install: |
apt-get update
apt-get install -y curl
curl -fsSL https://get.docker.com | sh
run: |
docker build --pull \
-t haskell:${{ matrix.ghc }}-${{ matrix.deb }} \
${{ matrix.ghc_minor }}/${{ matrix.deb }}
echo 'running official tests'
./official-images/test/run.sh haskell:${{ matrix.ghc }}-${{ matrix.deb }}
uses: nick-invision/retry@v1
with:
timeout_minutes: 8
max_attempts: 3
command: |
docker build --pull \
-t haskell:${{ matrix.ghc }}-${{ matrix.deb }} \
${{ matrix.ghc_minor }}/${{ matrix.deb }}
- uses: actions/checkout@v2
with:
repository: docker-library/official-images
path: official-images
- name: run official-images tests
run: ./official-images/test/run.sh haskell:${{ matrix.ghc }}-${{ matrix.deb }} |
AlistairB
force-pushed
the
travis-arm
branch
from
December 26, 2021 21:36
5f5b91f
to
e750c2d
Compare
AlistairB
force-pushed
the
travis-arm
branch
6 times, most recently
from
December 26, 2021 23:10
ca716c6
to
8062b6e
Compare
AlistairB
changed the title
Trying to get some CI ARM thing going
Add ARM64 processor architecture support
Dec 27, 2021
AlistairB
force-pushed
the
travis-arm
branch
5 times, most recently
from
January 1, 2022 21:50
4553c91
to
4270b8e
Compare
AlistairB
force-pushed
the
travis-arm
branch
6 times, most recently
from
January 4, 2022 21:11
00374ed
to
7521b1d
Compare
The current pattern did not work well for this, so the opportunity was taken to make improvements based on what other popular official images are doing.
There isn't much point to keeping them around, they out of date and not the newest pattern. If someone wanted a dockerfile with older versions they would be better off copying the pattern from the new dockerfiles. It is convenient to do this now as hadolint has been added to check the ARM related changes, but these old ones trigger failures.
AlistairB
force-pushed
the
travis-arm
branch
3 times, most recently
from
January 6, 2022 06:20
2d11e41
to
1bacc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
Superseeds #21
To Do
Finish setting up drone.io to test the ARM64 build. Waiting on my drone.io account being enabledMostly giving up in this.stack: /lib/aarch64-linux-gnu/libm.so.6: version 'GLIBC_2.29' not found (required by stack)
. I think the only solution is to remove stack entirely for ARM64. This is quite annoying though, as the haskell docker image smoke tests will check that stack is installed and working. HmmUpdate official image tests to gracefully ignore stack test on ARM64.Official image tests only run on amd64, so this isn't needed.