Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse topological ordering #638

Merged
merged 2 commits into from
Jul 17, 2020
Merged

reverse topological ordering #638

merged 2 commits into from
Jul 17, 2020

Conversation

jprider63
Copy link
Contributor

I needed the reverse topological ordering of a graph, so I exposed revTopSort. I'm not sure if GHC optimizes away reverse . reverse or not.

@treeowl
Copy link
Contributor

treeowl commented Jun 4, 2019

I'm all in favor, but please write a proposal on the libraries list to sort out the name.

@treeowl
Copy link
Contributor

treeowl commented Jun 4, 2019

Oh, and no, that's not optimized away.

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in favor, but please write a proposal on the libraries list to sort out the name.

I agree.

I'll "request changes" until that's done.

@jprider63 See https://mail.haskell.org/cgi-bin/mailman/listinfo/libraries.

If you have any questions, please ask!

@jprider63
Copy link
Contributor Author

Hi @sjakobi. I previously wrote a proposal here. Let me know if you need me to do anything else.

@treeowl
Copy link
Contributor

treeowl commented Jul 16, 2020

So the proposal was made, and got no response. Oh well. Let's just do this anyway, I think. Do you concur, @sjakobi?

@sjakobi sjakobi dismissed their stale review July 16, 2020 10:29

The proposal was discussed on the libraries list.

@sjakobi
Copy link
Member

sjakobi commented Jul 16, 2020

Thanks for the quick feedback, @jprider63! :)

I would somewhat prefer the name reverseTopSort – abbreviating "reverse" seems less warranted than abbreviating "topological". "reverse" also seems to mostly remain unabbreviated in other parts of the containers code base.

Does that seem like a reasonable change? Otherwise I'm +3/4 with the existing name too. ;)

@jprider63
Copy link
Contributor Author

reverseTopSort sounds good to me!

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@treeowl treeowl merged commit b1f248e into haskell:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants