-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverse topological ordering #638
Conversation
I'm all in favor, but please write a proposal on the libraries list to sort out the name. |
Oh, and no, that's not optimized away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all in favor, but please write a proposal on the libraries list to sort out the name.
I agree.
I'll "request changes" until that's done.
@jprider63 See https://mail.haskell.org/cgi-bin/mailman/listinfo/libraries.
If you have any questions, please ask!
So the proposal was made, and got no response. Oh well. Let's just do this anyway, I think. Do you concur, @sjakobi? |
The proposal was discussed on the libraries list.
Thanks for the quick feedback, @jprider63! :) I would somewhat prefer the name Does that seem like a reasonable change? Otherwise I'm +3/4 with the existing name too. ;) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I needed the reverse topological ordering of a graph, so I exposed
revTopSort
. I'm not sure if GHC optimizes awayreverse . reverse
or not.