Add stack.yaml file #463
Merged
Add stack.yaml file #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stack setup` fails due to ChasingBottoms missing from Stackage We default to lts-9.20 because lts-10.0 is currently not supported by many development tools (such as intero) because ghc-mod does not yet support GHC 8.2 (DanielG/ghc-mod#900). This was tested and works with resolvers lts-10.0 and lts-9.20. Using older resolvers <=lts-7.24 causes a conflict with the package ranges specified in containers.cabal.
The stack.yaml file is now provided when the containers repo is cloned.
treeowl
reviewed
Dec 27, 2017
|
Confirmed this will have no impact on Stackage snapshot generation: https://groups.google.com/forum/m/#!topic/haskell-stack/peD4SU0-S5c |
|
Excellent! Go right ahead then!
…On Dec 28, 2017 12:21 PM, "Matt Renaud" ***@***.***> wrote:
Confirmed this will have no impact on Stackage snapshot generation:
https://groups.google.com/forum/m/#!topic/haskell-stack/peD4SU0-S5c
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#463 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABzi_Wdl5vXpwN1DdgMYsttyNJGmznzZks5tE84HgaJpZM4RMk7H>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
stack initfails if you're using a resolver newer than lts-7.24 because ChasingBottoms has not been in Stackage LTS releases since then. Since Stack is a common workflow people use we should support the most recent Stackage LTS versions out of the box.In the stack.yaml file we add ChasingBottoms-1.3.1.3 as an extra-dep and default the resolver to 9.20 because lts-10.0 uses GHC 8.2 which is not supported all of the tools yet; ghc-mod is lacking support, for example. Once all tooling supports lts-10.0 we'll change the default resolver.
This also updates CONTRIBUTING.md, removing the
stack initstep because it is no longer needed.This resolves #458.