Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wmissing-home-modules warnings #444

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Fix -Wmissing-home-modules warnings #444

merged 1 commit into from
Dec 18, 2017

Conversation

RyanGlScott
Copy link
Member

Fixes #434.

@treeowl
Copy link
Contributor

treeowl commented Dec 18, 2017

I tried to fix this thing up, but goofed something up. Can you please rebase?

@RyanGlScott
Copy link
Member Author

Done.

@treeowl
Copy link
Contributor

treeowl commented Dec 18, 2017

Why do so many modules need to be listed so many places? Is there some way to restructure things to avoid this?

@RyanGlScott
Copy link
Member Author

Unfortunately, this is an annoying problem that many core libraries like containers face. What one would like to do is list containers as a library dependency in each test suite and benchmark, which would obviate the need to duplicate all of these other-modules. But containers' test suites and benchmarks depend on libraries which themselves depend on containers. For apparently technical reasons, this prevents us from listing containers as a library dependency there, because Cabal would be confused as to whether to link against the version of containers used to build the dependencies, or the version of containers you're building from source. (See haskell/cabal#4087 for an attempt to fix this issue in Cabal.)

Thus, we can't list containers as a library dependency, which means that we pretty much have to duplicate the other-modules for now. (A possible workaround for this in the future would be to list every thing in other-modules in a Cabal common stanza.)

@treeowl treeowl merged commit 4e88cad into haskell:master Dec 18, 2017
@treeowl
Copy link
Contributor

treeowl commented Dec 18, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants