Update and export set intersection utilities #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meooow25
force-pushed
the
set-intersections
branch
from
ee18abb
to
109f321
Compare
* Update Set.intersections to be lazier * Mark definitions INLINABLE for specialization * Add matching Intersection and intersections for IntSet * Add property tests
meooow25
force-pushed
the
set-intersections
branch
from
109f321
to
6c22110
Compare
|
@treeowl what is our stance on conditional exports? Is this controversial? If so, I will change it to use |
|
Looks like this would be in violation of the PVP FAQ: https://pvp.haskell.org/faq/#what-implications-does-the-pvp-have-for-conditional-apis I will make the change to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1038