Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haddock: use buildSettingKeepTempFiles #9966

Merged
merged 1 commit into from
May 10, 2024
Merged

Haddock: use buildSettingKeepTempFiles #9966

merged 1 commit into from
May 10, 2024
+80 −34

Conversation

sheaf
Copy link
Collaborator

@sheaf sheaf commented May 3, 2024 •
edited by alt-romes
Loading

This commit initialises the Haddock flag haddockKeepTempFiles with the value of buildSettingKeepTempFiles.

The only change in the patch is the following, in setupHsHaddockFlags:

- haddockKeepTempFiles = mempty -- TODO: from build settings
+ haddockKeepTempFiles = toFlag keepTmpFiles

where keepTmpFiles is retrieved from BuildTimeSettings.

This addresses an 8 year old TODO in the code.

Template Α: This PR modifies behaviour or interface.

TODO:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated.
  • Tests have been added.

@sheaf sheaf mentioned this pull request May 3, 2024
Open
10 tasks
@ffaf1
Copy link
Collaborator

ffaf1 commented May 3, 2024

@sheaf we need a template for PRs, and #9967 and #9968, with their checkboxes.

@alt-romes alt-romes force-pushed the haddock-tmpFiles branch from 7765d52 to abe7c47 Compare May 7, 2024 10:59
@alt-romes
Copy link
Collaborator

I've pushed a test. Ready for review.

@alt-romes alt-romes force-pushed the haddock-tmpFiles branch from abe7c47 to bb2da90 Compare May 7, 2024 11:01
ffaf1
ffaf1 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alt-romes alt-romes force-pushed the haddock-tmpFiles branch from bb2da90 to e2fc50e Compare May 7, 2024 13:25
@sheaf sheaf added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 7, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 9, 2024
@sheaf @Mikolaj
Haddock: use buildSettingKeepTempFiles
e35c0dc 
This commit initialises the Haddock flag haddockKeepTempFiles with the
value of buildSettingKeepTempFiles.

This addresses an 8 year old TODO in the code, from Duncan Coutts.
@Mikolaj Mikolaj force-pushed the haddock-tmpFiles branch from e2fc50e to e35c0dc Compare May 9, 2024 15:58
@mergify mergify bot merged commit 214acd8 into haskell:master May 10, 2024
51 checks passed
@ulysses4ever
Copy link
Collaborator

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jun 6, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffaf1 ffaf1 ffaf1 approved these changes

@geekosaur geekosaur geekosaur approved these changes

@andreabedini andreabedini Awaiting requested review from andreabedini

Assignees
No one assigned
Labels
Cabal: cmd/haddock merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sheaf @ffaf1 @alt-romes @ulysses4ever @geekosaur @Mikolaj