Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zlib.cabal location #9915

Merged
merged 1 commit into from
Apr 22, 2024
Merged

update zlib.cabal location #9915

merged 1 commit into from
Apr 22, 2024
+2 −2

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Apr 22, 2024 •
edited
Loading

The upstream zlib package was recently reorganized (haskell/zlib@c3809b5) in a way that caused our git fetch test to fail. Update it to match.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur
update zlib.cabal location
2ad9d63 
The upstream zlib package was recently reorganized in a way that
caused our git fetch test to fail. Update it to match.
@geekosaur
Copy link
Collaborator Author

Since the cabal-install test suite will fail until this goes in, we probably want to fast-track it.

Mikolaj
Mikolaj approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great detective work!

@Mikolaj Mikolaj added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 22, 2024
ulysses4ever
ulysses4ever approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job!

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Apr 22, 2024
@mergify mergify bot merged commit 959d72b into haskell:master Apr 22, 2024
51 checks passed
@Mikolaj
Copy link
Member

Mikolaj commented Apr 22, 2024

Nobody objected here not on the channel, so it went through the express way. Let's also fast-track the backport.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 22, 2024

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 22, 2024
Merged
2 tasks
@ulysses4ever ulysses4ever mentioned this pull request Apr 22, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Apr 23, 2024
@mergify
Merge pull request #9916 from haskell/mergify/bp/3.12/pr-9915
f687159 
update zlib.cabal location (backport #9915)
@jasagredo jasagredo mentioned this pull request Jun 14, 2024
Open
@geekosaur geekosaur deleted the zlib-upstream branch July 18, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
cabal-install: tests/unit-tests merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekosaur @Mikolaj @ulysses4ever