Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused packages #9855

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Conversation

philderbeast
Copy link
Collaborator

Fixes #9853. I am a bit frustrated that I've not been able fix or suppress the -Werror=unused-package with cabal-testsuite except with the following setting in project-cabal/ghc-options.config;

package cabal-testsuite
  ghc-options: -Wwarn=unused-packages

I tried adding similar ghc-options to cabal-testsuite:test:test-runtime-deps (the intentional source of unused package dependencies) but suppose project settings override package settings.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast philderbeast force-pushed the fix/remove-unused-packages branch from e4359a7 to 9416e17 Compare March 29, 2024 17:02
@philderbeast
Copy link
Collaborator Author

@Mikolaj don't know what is going on with CI but the validate old ghc jobs are all failing with;

Run haskell-actions/setup@v2
/usr/bin/docker exec  9757b91719926d88402087692c8f087a5632be69e683d1466bd001285e16eb96 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)

@philderbeast
Copy link
Collaborator Author

I ran locally something close to Validate old ghcs 8.4.4 and found one unexpected pass;

$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.8.4

$ sh validate.sh -j 24 -v -s build

$ sh validate.sh -j 24 -v --lib-only -s lib-suite-extras --extra-hc ghc-8.4.4
...
PackageTests/ForeignLibs/setup.test.hs     FAIL (unexpected success) (2.98s)
...
532 tests, 390 skipped, 1 unexpected passes, 0 unexpected fails.
UNEXPECTED OK: PackageTests/ForeignLibs/setup.test.hs
...

@philderbeast
Copy link
Collaborator Author

The Validate old ghcs problem is #9858.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Much needed Spring cleaning. :)

@philderbeast philderbeast force-pushed the fix/remove-unused-packages branch from 94aef6a to c1298e6 Compare April 6, 2024 12:01
@philderbeast philderbeast requested a review from geekosaur April 6, 2024 12:02
- Remove stm and containers from hackage-tests
- Remove tasty-expected-failure from check-tests
- Remove tasty-quickcheck from parser-tests
- Remove async, binary, Cabal-tests, deep-seq, integer-logarithms, rere, tagged and transformers from unit-tests
Use -Wwarn=unused-packages for cabal-testsuite
@philderbeast
Copy link
Collaborator Author

Label merge+no rebase is necessary when the pull request is from an organisation.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 8, 2024
@mergify mergify bot merged commit d7147fc into haskell:master Apr 8, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with -Werror=unused-packages
3 participants