Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize use of brew in GitLab CI #8836

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Stabilize use of brew in GitLab CI #8836

merged 2 commits into from
Mar 9, 2023

Conversation

chreekat
Copy link
Collaborator

@chreekat chreekat commented Mar 9, 2023 •
edited
Loading

Use a specific release instead of HEAD.

Darwin job: https://gitlab.haskell.org/haskell/cabal/-/jobs/1399049

Please include the following checklist in your PR:

Mikolaj
Mikolaj approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chreekat
Copy link
Collaborator Author

chreekat commented Mar 9, 2023

Note that the (existing, unchanged) brew update line will change the version of brew anyway. This just uses a known-good version as a base on runners that don't have it cached yet.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 9, 2023

I will fast-merge as soon as CI finishes. but a second review is welcome anyway.

@Mikolaj Mikolaj added continuous-integration release merge me Tell Mergify Bot to merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Mar 9, 2023
@mergify mergify bot merged commit fda8100 into haskell:master Mar 9, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Mar 9, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@mergify mergify bot mentioned this pull request Mar 9, 2023
Merged
mergify bot added a commit that referenced this pull request Mar 9, 2023
@mergify
Merge pull request #8837 from haskell/mergify/bp/3.10/pr-8836
6c95f3f 
Stabilize use of brew in GitLab CI (backport #8836)
@chreekat chreekat deleted the wip/b/stabilize-brew branch August 8, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chreekat @Mikolaj @ulysses4ever