Apply command line flags to install packages (#8637)

[patrickdoc]

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

---

This PR reverses the effects of #7973 specifically for targets of the "install" command to more closely match expected behavior.

Before this change:

cabal v2-install --ghc-option=-foo hello

would not apply "-foo" to "hello" because "hello" is not a local package. After this change, -foo is applied to "hello" because it is a direct target of the install command, so gets the local package configs added to it.

To test, I ran:

cabal install --ghc-option=-foo alex --verbose

which resulted in:

# Installation of "directory" dependency, no "-foo" flag present
/home/patrick/projects/haskell/cabal/dist-newstyle/build/x86_64-linux/ghc-9.2.3/cabal-install-3.9.0.0/x/cabal/build/cabal/cabal
act-as-setup --build-type=Configure -- configure --verbose=2 --builddir=dist
--ghc
--prefix=/home/patrick/.cabal/store/ghc-9.2.3/directory-1.3.8.0-
<snip>
--ghc-option=-hide-all-packages

# Installation of "alex" package, "-foo" flag present
/home/patrick/projects/haskell/cabal/dist-newstyle/build/x86_64-linux/ghc-9.2.3/cabal-install-3.9.0.0/x/cabal/build/cabal/cabal
act-as-setup --build-type=Simple -- configure --verbose=2 --builddir=dist
--ghc
--prefix=/home/patrick/.cabal/store/ghc-9.2.3/alex...
<snip>
--ghc-option=-hide-all-packages --ghc-option=-foo exe:alex

[Mikolaj]

@patrickdoc: do you need any help with that one?

[patrickdoc]

@Mikolaj As far as I can tell my change functions as expected, but it is triggering an unexpected pass in the testsuite for this one:
#8744

I read a bit of the conversation around that test, but haven't had a chance to fully understand the original change + the fallout from it. The topics are related enough that I believe I might be fixing the original issue, but it's tough to say.

[Mikolaj]

@gbaz: any clue?

[gbaz]

I think that the test should be revised to pass -- which is the desired behavior. In other words, this pr fixes one of the two issues in #8623 in a more correct way than that change did!

[gbaz]

updated the branch with flipping the test expectation

[Mikolaj]

@patrickdoc: is it fine? anything else? if not, would you set a squash+merge_me or merge_me label? I'd like to backport ASAP

[patrickdoc]

Label added

[Mikolaj]

If Gershom says this is correct then this is correct. @gbaz, do you?

[Mikolaj]

Let me fast-track the merge process.

[Mikolaj]

@mergify rebase

[mergify]

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

[mergify]

rebase

✅ Branch has been successfully rebased

[Mikolaj]

@mergify backport 3.10

[mergify]

backport 3.10

✅ Backports have been created

• #8811 Apply command line flags to install packages (#8637) (backport #8779) has been created for branch 3.10