Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around ghcup cache woes also in our tiny CI scripts #8743

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Feb 8, 2023

This is a continuation of #8739, which fixed a CI problem that now shows up also in these scripts. I hope there is no more affected code.

@Mikolaj Mikolaj force-pushed the try-chmod-to-fix-CI-part2 branch from e8e317a to 7310c94 Compare February 8, 2023 15:09
@Mikolaj Mikolaj merged commit 4756705 into haskell:master Feb 8, 2023
# See https://github.com/haskell/cabal/pull/8739
- name: Sudo chmod to permit ghcup to update its cache
run: |
if [[ "${{ runner.os }}" == "Linux" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little smartass remark: This conditional can reside at the level of the action language, like:

      if: ${{ runner.os == 'Linux' }}

This will then display the step as skipped on macOS/Windows. If one wants such a thing.
(This smartass remark is part of my personal quest to find best practices for github workflows. No need to act.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smartass indeed. :D

@Mikolaj
Copy link
Member Author

Mikolaj commented Feb 13, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

backport 3.10

✅ Backports have been created

mergify bot added a commit that referenced this pull request Feb 13, 2023
Work around ghcup cache woes also in our tiny CI scripts (backport #8743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants