elim warning spam from #8500

[gbaz]

This removes the warning spam from #8500

Now we check if a file exists before attempting to compute the hash of it. Doh.

[gbaz]

@Mikolaj if this works for you I think we should just give it an expedited merge and backport.

[Mikolaj]

This accesses the filesystem again for the same package and, for a few packages, their files would not be accessed at all if not for this extra check, if my guesses in #8500 were right. However, on sensible OSes, by this point, most of the time, all the relevant filesystem info is in RAM anyway.

[gbaz]

Before, we always just tested if the file exists, which just accessed metadata. Here, we have to do that, and on top of that, if it does exist, actually hash it. But that's the point of the check :-)

[gbaz]

https://github.com/Mergifyio backport 3.10

[mergify]

backport .10

❌ No backport have been created

• Backport to branch .10 failed: Branch not found

[mergify]

backport 3.10

✅ Backports have been created

• #8698 elim warning spam from #8500 (backport #8697) has been created for branch 3.10

[Mikolaj]

Before, we always just tested if the file exists, which just accessed metadata. Here, we have to do that, and on top of that, if it does exist, actually hash it. But that's the point of the check :-)

I don't remember how it was before. But now doesFileExist is performed twice for the same package, once in checkRepoTarballFetched and again in the new code you just added. Fortunately, if the package is going to be hashed or, worse, downloaded, this is totally negligible.

[gbaz]

Pretty sure checkRepoTarballFetched is only called on repoTarballPkgsWithoutMetadata -- the new path is only called on the other set of packages, those which have metadata to validate :-)

[Mikolaj]

You are probably right.