Document multiple public libraries #8364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
reviewed
Aug 11, 2022
jneira
reviewed
Aug 11, 2022
fgaz
force-pushed
the
multilibs-docs
branch
2 times, most recently
from
70a57da to
31124dc
Compare
jneira
approved these changes
Aug 11, 2022
|
I suppose it is fine to backport it to 3.8 |
Mikolaj
approved these changes
Aug 11, 2022
|
@mergify backport 3.8 |
✅ Backports have been created
|
|
If you don't mind I'm going to skip the 2 day waiting period, so that 3.8 will have multilibs docs in time for the discourse announcement |
That's a good idea. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
mergify bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
(cherry picked from commit f4270fc)
fgaz
added a commit
that referenced
this pull request
Aug 11, 2022
Document multiple public libraries (backport #8364)
|
@fgaz ah, thank you so much for this PR, I just stumbled across the passive-aggressive sentences that you fix and I was about to raise a ticket :D |
|
@Kleidukos you're welcome, but what was passive-aggressive about that? |
The ellipses at the end of each sentence :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About time I write this :D
Closes #6362
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!