Fix optional test-suite/benchmark type docs #8344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Mikolaj
approved these changes
Aug 8, 2022
ulysses4ever
approved these changes
Aug 8, 2022
|
@cydparser thank you! Feel free to apply the merge-me label when you're ready (or signal if you don't have the permissions). It will take two more days for Mergify to merge. |
andreabedini
force-pushed
the
fix-optional-type-docs
branch
from
2444057 to
efd3f4f
Compare
|
@mergify rebase |
✅ Branch has been successfully rebased |
andreabedini
force-pushed
the
fix-optional-type-docs
branch
from
efd3f4f to
1821cfd
Compare
andreasabel
approved these changes
Aug 11, 2022
andreabedini
force-pushed
the
fix-optional-type-docs
branch
from
1821cfd to
556d1e6
Compare
|
Let me rebase to include a workaround to our CI instability and fix the tests. |
|
@mergify rebase |
✅ Branch has been successfully rebased |
ulysses4ever
force-pushed
the
fix-optional-type-docs
branch
from
556d1e6 to
51b1278
Compare
|
@mergify backport 3.8 |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Aug 19, 2022
Fix optional test-suite/benchmark type docs (backport #8344)
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses documentation changes requested in PR #8115. I've reverted some additional changes that I made, since the original PR made type optional for all cabal-version's, but PR #8138 limited change to versions >= 3.8.