Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off T3827 for Linux and OSX due to heisenbugs not caused by cabal #8338

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Aug 3, 2022

An emergency CI fix to unblock CI passing for #8336 and probably others. See #8032 (comment) for more info.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 3, 2022

Doh, the very test now failed for ghc-8.0.2 on Linux. Let me rerun and hope it's a one-time fluke.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 3, 2022

Now it fails with GHC 8.8.4. I'm going to disable this on Linux totally until #8032 (comment) is done.

@Mikolaj Mikolaj force-pushed the heisenbug-8335 branch 2 times, most recently from b618c18 to 8454c7c Compare August 3, 2022 20:47
@Mikolaj Mikolaj changed the title Turn off T3827 for new GHCs due to heisenbugs not caused by cabal Turn off T3827 for Linux and OSX due to heisenbugs not caused by cabal Aug 3, 2022
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 3, 2022

AFAIU, GHA cache picked up some GHC bindists without profiling and our profiling test fails whenever we use this particular cache item (but it's non-deterministic which GHA cache item we use, so we can't adapt the test). See #8032 (comment)

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burn it!

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 4, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2022

rebase

✅ Branch has been successfully rebased

@Mikolaj Mikolaj merged commit 91a343f into haskell:master Aug 4, 2022
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 10, 2022

@mergify backport 3.8

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 10, 2022

It now also affect 3.8, so backporting.

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2022

backport 3.8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 10, 2022
#8338)

* Turn off T3827 for new GHCs due to heisenbugs not caused by cabal

* Disable the test totally on Linux until we stop taking GHC from GHA

See #8032 (comment)

* It failed on OSX now, so let's disable it everywhere except on Windows

Who would have thought.

(cherry picked from commit 91a343f)
Mikolaj added a commit that referenced this pull request Aug 10, 2022
Turn off T3827 for Linux and OSX due to heisenbugs not caused by cabal (backport #8338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants