-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: GHC 9.2.1 -> 9.2.2 #8253
CI: GHC 9.2.1 -> 9.2.2 #8253
Conversation
Hah, long overdue. Why not 9.2.3? |
I need to double check but I think one could omit the minor version entirely. “9.2” would mean the latest “9.2.x”. |
Thanks for suggestions. I can switch to 9.2.3 or 9.2 What concerns me is that there’s a new failure on 9.2.2 with haddock in a backpack test. This combination sounds scary to me! (I found out about it accidentally when looking what could be done with #8032.) This failure also shows that not pinning the minor release can bring surprises, and I’d rather pin it as before. |
Link to the failed job: https://github.com/haskell/cabal/runs/7050959899?check_suite_focus=true Meanwhile, trying 9.2.3. |
Same failure for 9.2.3. Also reproduces locally. |
yeah unfortunately it is not uncommon that ghc minor versions breaks things. |
Oh, so the failure is due to "expect fail" on those tests (introduced in #8022) was very (I'd say: too) specific about version of GHC it covers. I propose changing
The actual ticket investigating the problem is #7987. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100/100
(oops reflexively hit the "delete branch" button, guess it doesn't hurt) |
It's all good @robx. I should have done it myself. |
Don't worry, I delete random things on impulse all the time. |
@Mergifyio backport 3.8 |
✅ Backports have been created
|
CI: GHC 9.2.1 -> 9.2.2 (backport #8253)
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!