-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: generate missing Setup.hs in dependencies #8194
Conversation
CI Validate windows-latest ghc-8.6.5 failed randomly with
Restarting the tests. |
And now the tests pass fine. Let me remove the flaky CI combo in another PR, because it's at least the second time exactly the same test fails randombly in the same way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
Let me press the red button, since this needs to be backported, too. Thank you, @robx! |
This allows bootstrapping against zlib 0.6.3.0, which ships without Setup.hs. I hope this should generally be a more robust approach than asking maintainers of dependencies to keep Setup.hs.
2d970cc
to
5afa86b
Compare
@Mergifyio backport 3.8 |
✅ Backports have been created
|
bootstrap: generate missing Setup.hs in dependencies (backport #8194)
This allows bootstrapping against zlib 0.6.3.0, which ships
without Setup.hs.
I hope this should generally be a more robust approach than
asking maintainers of dependencies to keep Setup.hs.
Testing: I ran the bootstrap successfully locally, with the zlib version updated to 0.6.3.0.