Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: generate missing Setup.hs in dependencies #8194

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

robx
Copy link
Collaborator

@robx robx commented Jun 3, 2022

This allows bootstrapping against zlib 0.6.3.0, which ships
without Setup.hs.

I hope this should generally be a more robust approach than
asking maintainers of dependencies to keep Setup.hs.

Testing: I ran the bootstrap successfully locally, with the zlib version updated to 0.6.3.0.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 3, 2022

CI Validate windows-latest ghc-8.6.5 failed randomly with

C:\Users\RUNNER~1\AppData\Local\Temp\ghcFEDE.c: DeleteFile "\\\\?\\C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\ghcFEDE.c": permission denied (Access is denied.)

Restarting the tests.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 3, 2022

And now the tests pass fine. Let me remove the flaky CI combo in another PR, because it's at least the second time exactly the same test fails randombly in the same way.

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 7, 2022

Let me press the red button, since this needs to be backported, too. Thank you, @robx!

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Jun 7, 2022
This allows bootstrapping against zlib 0.6.3.0, which ships
without Setup.hs.

I hope this should generally be a more robust approach than
asking maintainers of dependencies to keep Setup.hs.
@mergify mergify bot merged commit a155b07 into haskell:master Jun 8, 2022
@fgaz
Copy link
Member

fgaz commented Jun 8, 2022

@Mergifyio backport 3.8

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

backport 3.8

✅ Backports have been created

Mikolaj added a commit that referenced this pull request Jun 8, 2022
bootstrap: generate missing Setup.hs in dependencies (backport #8194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants