Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX List v3.16 to LicenseListVersion and the file format changelog #8135

Merged
merged 1 commit into from
May 19, 2022
Merged

Add SPDX List v3.16 to LicenseListVersion and the file format changelog #8135

merged 1 commit into from
May 19, 2022

Conversation

Kleidukos
Copy link
Member

Follow-up of #8127

@Kleidukos Kleidukos requested review from Mikolaj and fgaz May 10, 2022 16:46
@fgaz
Copy link
Member

fgaz commented May 10, 2022

There might be something more to add, compare

git grep LicenseListVersion_3_10

and

git grep LicenseListVersion_3_16

looking at past commits that touch the files could help

@Mikolaj Mikolaj mentioned this pull request May 10, 2022
Merged
3 tasks
@Mikolaj
Copy link
Member

Mikolaj commented May 16, 2022

@Kleidukos: what do you think about what @fgaz's mentioned?

@Kleidukos
Copy link
Member Author

Yes that's excellent!
I've seen the stuff that's missing, I'll add them today :)

@Kleidukos Kleidukos force-pushed the update-spdx-list-to-3-16 branch from 17924f9 to 48a444a Compare May 16, 2022 11:01
@Kleidukos
Copy link
Member Author

@Mikolaj @fgaz Updated!

Mikolaj
Mikolaj approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Once this merges I will cut 3.8.

Cabal-syntax/src/Distribution/SPDX/LicenseId.hs
, BSD_2_Clause_FreeBSD
, BSD_2_Clause_Views
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so the list for 3.10 was buggy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup' :(

@Mikolaj
Copy link
Member

Mikolaj commented May 18, 2022

Actually, I will cut 3.8 without waiting for the merge. I'd like to report problems on tomorrow's meeting, if any. Let's remember to backport this to 3.8 once it merges.

@Kleidukos Kleidukos force-pushed the update-spdx-list-to-3-16 branch from 48a444a to c45bb0e Compare May 19, 2022 13:58
fgaz
fgaz approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kleidukos Kleidukos merged commit a530988 into haskell:master May 19, 2022
@Kleidukos Kleidukos deleted the update-spdx-list-to-3-16 branch May 19, 2022 16:15
@fgaz
Copy link
Member

fgaz commented May 19, 2022

@Mergifyio backport 3.8

@mergify
Copy link
Contributor

mergify bot commented May 19, 2022

backport 3.8

❌ No backport have been created

  • Backport to branch 3.8 failed: Branch not found

@fgaz
Copy link
Member

fgaz commented May 19, 2022

Oh oops we didn't branch-off yet

@Mikolaj
Copy link
Member

Mikolaj commented May 19, 2022

We did now. With this PR included for free. :)

@Mikolaj Mikolaj mentioned this pull request Feb 24, 2023
Open
@ffaf1 ffaf1 mentioned this pull request Mar 31, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgaz fgaz fgaz approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kleidukos @fgaz @Mikolaj