Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow glob matches of the form dir/**/FileNoExtension #8005

Merged
merged 6 commits into from
Apr 13, 2022
Merged

allow glob matches of the form dir/**/FileNoExtension #8005

merged 6 commits into from
Apr 13, 2022

Conversation

gbaz
Copy link
Collaborator

@gbaz gbaz commented Feb 21, 2022 •
edited
Loading

Resolves #5883

Mikolaj
Mikolaj approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj
Copy link
Member

Mikolaj commented Mar 2, 2022

A changelog would be necessary, though. And a test would be welcome. :)

@jneira
Copy link
Member

jneira commented Mar 10, 2022

@Mergifyio rebase master

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2022

rebase master

✅ Branch has been successfully rebased

@jneira jneira force-pushed the gb/allow-globstar-literalfile branch from efbbfa3 to 2bbfc5c Compare March 10, 2022 17:05
@jneira
Copy link
Member

jneira commented Mar 18, 2022

@Mergifyio rebase master

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

rebase master

✅ Branch has been successfully rebased

@jneira jneira force-pushed the gb/allow-globstar-literalfile branch from 2bbfc5c to c3efbb4 Compare March 18, 2022 21:57
@gbaz
Copy link
Collaborator Author

gbaz commented Mar 26, 2022

Tests, changelog, docs done. ready for review and merge.

@gbaz gbaz added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Apr 13, 2022
@mergify mergify bot merged commit f60c9d7 into master Apr 13, 2022
@cnr cnr mentioned this pull request Jul 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilypi emilypi emilypi approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the concept of "file extension" from data-files/extra-source-files wildcards
4 participants
@gbaz @Mikolaj @jneira @emilypi