Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log package hash inputs file and contents / regression test for #6906 #7759

Merged
merged 10 commits into from
Oct 18, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 18, 2021

Example of new output including package hash file creation and its contents:

creating
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790\bin
creating
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790
creating D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5
creating D:\cs2\ghc-8.6.5\incoming\new-13688\cs2
creating D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5
creating
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790
creating
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790\bin
Installing executable dist\build\issue6906\issue6906.exe to
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790\bin\issue6906.exe
creating
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790
creating file with the inputs used to compute the package hash:
D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5\issue6906-0-676b6bdd8037cf9b726f4f7ca0e541f97bbfe790\cabal-hash.txt
Package hash inputs:
> pkgid: issue6906-0
> component: ComponentExe (UnqualComponentName "issue6906")
> src: b812ce34d1d6b8ed44807c8c8c3c4a97634ddc980ef40f09b2406cca1f6b9885
> pkg-config-deps:
> deps: base-4.12.0.0
> compilerid: ghc-8.6.5
> platform: x86_64-windows
> stripped-exe: False
> debug-info: 0
> extra-lib-dirs: bar bar
> extra-include-dirs: foo foo

@jneira jneira requested review from phadej and gbaz October 18, 2021 07:08
@jneira jneira changed the title Log package hash inputs file and contants and regression test for #6906 Log package hash inputs file and contents / regression test for #6906 Oct 18, 2021
@jneira
Copy link
Member Author

jneira commented Oct 18, 2021

Note the funny duplication and lack of ordering of the preexisting log:

creating D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5
creating D:\cs2\ghc-8.6.5\incoming\new-13688\cs2
creating D:\cs2\ghc-8.6.5\incoming\new-13688\cs2\ghc-8.6.5

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changelog entry would be 👍 thanks @jneira

@jneira
Copy link
Member Author

jneira commented Oct 18, 2021

A changelog entry would be +1 thanks @jneira

i hope the one added in the follow up #7753 with b3ebb00, which also mentions this one could work

@Mikolaj
Copy link
Member

Mikolaj commented Oct 18, 2021

Reviewing...

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TDD at its best.

@jneira
Copy link
Member Author

jneira commented Oct 18, 2021

TDD at its best

Well i did the fix before the tests but only the pr id would peach it 😉

@jneira jneira added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Oct 18, 2021
@mergify mergify bot merged commit 980a532 into haskell:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants