-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change cabal-plan list-bin to cabal list-bin in Makefile #7648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked!
cabal list-bin was introduced in cabal-install 3.4, so it's safe to assume every cabal developer has it by now. By using that, we remove the dependency on cabal-plan from the Makefile (though it's still present in other places).
5c02dfa
to
42c0599
Compare
@fgaz
Could be a problem with case-insensitivity. @fgaz After our conversation where you mentioned that Suggestion: revert this PR (at #7675). (I have to do it anyway on my machine.) |
case insensitive file system strikes again. So dumb. |
Even then, there's also a problem in... sensible file systems, and when a qualified target is used:
This definitely looks like a bug in list-bin, and a bad error message: is it zero, or multiple? This is not fixed by #7408 by the way. So yes, let's revert for now. I also opened #7679 to track the bug. P.S.: yes, I originally only checked a couple of invocations and assumed it worked the same for all others, sorry.. |
cabal list-bin was introduced in cabal-install 3.4, so it's safe to
assume every cabal developer has it by now. By using that, we
remove the dependency on cabal-plan from the Makefile (though it's still
present in other places).
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
I'm not sure if CI will be fine with this though. some jobs are run with older images. on the other hand, CI doesn't use many make commands. let's see...