Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional examples in doc of tested-with (fix #4894) #7604

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

andreasabel
Copy link
Member

Fix #4894: document alternatives to write a tested-with list

A grab-bag of alternatives as discussed at #4894.

This PR is based on PR #7603 to get extra sphinx sanity checking.

@andreasabel andreasabel requested a review from phadej August 31, 2021 15:29
@andreasabel andreasabel changed the title Issue4894 Additional examples in doc of tested-with (fix #4894) Aug 31, 2021
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

doc/cabal-package.rst Outdated Show resolved Hide resolved
@Mikolaj Mikolaj mentioned this pull request Aug 31, 2021
3 tasks
andreasabel added a commit to andreasabel/cabal that referenced this pull request Sep 2, 2021
@emilypi
Copy link
Member

emilypi commented Sep 11, 2021

Looks good @andreasabel! Please resolve the merge conflicts and i'm happy to merge into master :)

@emilypi emilypi added the squash+merge me Tell Mergify Bot to squash-merge label Sep 11, 2021
andreasabel added a commit to andreasabel/cabal that referenced this pull request Sep 11, 2021
@andreasabel
Copy link
Member Author

Looks good @andreasabel! Please resolve the merge conflicts and i'm happy to merge into master :)

Thanks, @emilypi. I rebased this on current master.

Note that a recent merge introduced problems into the docs, but this should not affect my PR here...

@Mikolaj
Copy link
Member

Mikolaj commented Sep 11, 2021

@andreasabel: I hope the problems are gone now.

@emilypi emilypi added merge me Tell Mergify Bot to merge and removed squash+merge me Tell Mergify Bot to squash-merge labels Sep 11, 2021
@mergify mergify bot merged commit 5d0d958 into haskell:master Sep 13, 2021
@andreasabel andreasabel deleted the issue4894 branch September 13, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of field tested-with
3 participants