Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop obsolete Backpack warning from Chapter 6. (See: #6005) #7518

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

lechner
Copy link
Collaborator

@lechner lechner commented Aug 6, 2021

With Backpack interoperability problems now resolved, the related warnings in
the documentation can probably be removed. [1]

Drops the sole warning located by a text search for "6005".

[1] #6005 (comment)


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

With Backpack interoperability problems now resolved, the related warnings in
the documentation can probably be removed. [1]

Drops the sole warning located by a text search for "6005".

[1] haskell#6005 (comment)
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!


Getting the soon-to-be-default docs to show this too:

@Mergifyio backport 3.6

@fgaz
Copy link
Member

fgaz commented Aug 6, 2021

...i guess the bot doesn't work on review comments

@Mergifyio backport 3.6

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2021

Command backport 3.6: pending

Waiting for the pull request to get merged

@lechner
Copy link
Collaborator Author

lechner commented Aug 6, 2021

Hi, I only see an annotation An error occurred while provisioning resources (Error Type: Disconnect) but no log. There is no restart button.

Please let me know if my PR is deficient. I am happy to push an update.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 6, 2021

@lechner: have your PR permanently broken CI?

No, I don't think so. :) Seems just a fluke. I'm now trying to restart it.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 7, 2021

Looks perfect. Merging.

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2021

Command backport 3.6: success

Backports have been created

emilypi added a commit that referenced this pull request Aug 7, 2021
Drop obsolete Backpack warning from Chapter 6. (See: #6005) (backport #7518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants