Prefer ProjectFlags over additional field in OutdatedFlags #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
polish/project-flags
branch
2 times, most recently
from
3781754 to
c0bc4e2
Compare
fendor
force-pushed
the
polish/project-flags
branch
from
c0bc4e2 to
62c8226
Compare
emilypi
approved these changes
Jun 14, 2021
|
Windows CI seems to be borked. Let's hope only that one. |
fgaz
reviewed
Jun 15, 2021
fgaz
approved these changes
Jun 15, 2021
fendor
force-pushed
the
polish/project-flags
branch
from
4c26cab to
62c8226
Compare
Since most commands use 'ProjectFlags' but almost all commands can not function properly without a project context, some commands manually strip the flag '-z' (--ignore-project) from the command line option parser. Unify the behaviour for all commands.
fendor
force-pushed
the
polish/project-flags
branch
from
62c8226 to
682a639
Compare
shapr
added a commit
to shapr/cabal
that referenced
this pull request
Oct 20, 2023
The nearly identical PR for haskell#7439 was used as a guide for this PR. The point of this PR is to reduce the duplication of project flag handling. Co-authored-by: Jean-Paul Calderone <[email protected]>
1 task
mergify bot
added a commit
that referenced
this pull request
Oct 25, 2023
* Use ProjectFlags to define CleanCmd The nearly identical PR for #7439 was used as a guide for this PR. The point of this PR is to reduce the duplication of project flag handling. Co-authored-by: Jean-Paul Calderone <[email protected]> * remove duplicate support for project-dir * switch use of NamedFieldPuns to RecordWildCards --------- Co-authored-by: Jean-Paul Calderone <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6815
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
I tested it manually that it uses the correct freeze file.