-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ghci being launched before other sources are built #6923
Conversation
8d72466
to
d063542
Compare
ping @phadej |
This looks like an accident from a6e427a It causes cases like this to fail: $ cat foo.c int foo() { return 42; } $ cat Lib.hs module Lib where foreign import ccall "foo" foo :: Int bar = foo $ cat cabal-csrc-repl.cabal cabal-version: 2.4 name: cabal-csrc-repl version: 0.1.0.0 library exposed-modules: Lib build-depends: base ^>=4.14.0.0 C-sources: foo.c default-language: Haskell2010 $ cabal v2-repl Resolving dependencies... Build profile: -w ghc-8.10.1 -O1 In order, the following will be built (use -v for more details): - cabal-csrc-repl-0.1.0.0 (lib) (first run) Configuring library for cabal-csrc-repl-0.1.0.0.. Preprocessing library for cabal-csrc-repl-0.1.0.0.. GHCi, version 8.10.1: https://www.haskell.org/ghc/ :? for help [1 of 1] Compiling Lib ( Lib.hs, interpreted ) Ok, one module loaded. *Lib> foo ghc: ^^ Could not load '_foo', dependency unresolved. See top entry above.
d063542
to
e3d2608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have troubles writing a changelog entry for this fix. The title of this PR doesn't make sense standalone. |
@phadej maybe something like
|
I'm suspecting changes in If it so, I'll will revert this PR. EDIT: see https://lists.gforge.inria.fr/pipermail/cado-nfs-commits/2015-August/005301.html
|
Update, it wasn't that. With
also fails. I.e. inheriting stdin makes cabal fail |
Backported to 3.2 in #7134 |
The following case previously failed
Looks like an accident from a6e427a