Rebuild on changes in all extra-source-files #6889
Merged
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should alleviate haskell#4746 for most use cases, if the dependent files are declared in `extra-source-files`. The downside is that `cabal` will not be able to avoid invoking GHC in as many cases, but GHC's `--make` should be smart enough to avoid any "actual" rebuilding that isn't necessary.
|
Stuff in And stuff like This is simpler and there are no real drawbacks either. Thanks! |
georgefst
added a commit
to georgefst/monpad
that referenced
this pull request
Dec 22, 2020
Elm wasn't being caught. I had changed to explicit paths when investigating rebuilds, but it was a red herring - I hadn't realised this fix was only in Cabal 3.4 and I'm using 3.2: haskell/cabal#6889.
georgefst
added a commit
to georgefst/monpad
that referenced
this pull request
Mar 10, 2021
Needed for cabal to know it needs to rebuild stuff when they change. In 0ded0ff I expected that haskell/cabal#6889 would make this work even for wildcards but this is not the case. A proper fix for haskell/cabal#4746 is probably needed instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should alleviate #4746 for most use cases, if the dependent files
are declared in
extra-source-files. The downside is thatcabalwill not be able to avoid invoking GHC in as many cases, but GHC's
--makeshould be smart enough to avoid any "actual" rebuilding thatisn't necessary.
changelog.ddirectory).Please also shortly describe how you tested your change. Bonus points for added tests!