WINIO: Add support for WINIO to Cabal. #6848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
from
8252951 to
21e265e
Compare
phadej
reviewed
May 28, 2020
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
from
21e265e to
f996a72
Compare
|
I'm not sure what happened with Quick jobs. I noticed that "Add Cabal, GHC... to GitHub iActions mages* issues was resolved, so it might or might not related. |
phadej
reviewed
Jun 11, 2020
| @@ -36,10 +40,17 @@ import qualified System.Posix | |||
| -- TODO: This file should probably be removed. | |||
|
|
|||
| -- This is a copy/paste of the openBinaryTempFile definition, but | |||
| -- if uses 666 rather than 600 for the permissions. The base library | |||
| -- needs to be changed to make this better. | |||
| -- if uses 666 rather than 600 for the permissions. Newer versions | |||
|
The Quick jobs failed, (#6890 will fix them soon). |
|
@Mistuke Could you fix a typo and rebase on top of |
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
from
f996a72 to
6ec7bdb
Compare
|
@phadej not sure what that CI failure is.. seems to have failed checkout? |
|
CI was green in #6908 (with the same commit). I merged it. If there is still something please open a followup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
openNewBinaryFileuseopenBinaryTempFileWithDefaultPermissionson Windows when the new I/O manager is used. It's my understanding that the only difference between the two is the file mode?666vs600. Howeverbasehas supprtedopenBinaryTempFileWithDefaultPermissionsfor a while now with666as permissions.Without this any calls to
openNewBinaryFilein GHC 8.12 and the new I/O manager enabled will cause a panic.Related to #6847
Please include the following checklist in your PR:
changelog.ddirectory).Please also shortly describe how you tested your change. Bonus points for added tests!