Refactor FieldGrammar / Described #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes type-signatures awful, but using _ one can infer them. Parsing performance doesn't seem to be affected. Also move Newtypes to Distribution.FieldGrammar.Newtypes as that is more correct place.
phadej
force-pushed
the
describe-refactor-b
branch
2 times, most recently
from
e9afb92 to
ff85fe5
Compare
Move Described functionality there, out of Cabal the library. Similarly cabal-install doesn't contain Described instances, they are only in tests.
phadej
force-pushed
the
describe-refactor-b
branch
from
ff85fe5 to
f7ee3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR this moves Described to tests out of library/executable.