-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FileCreators.generateCabalFile unit tests. #6678
Conversation
2454660
to
abdf2d7
Compare
cabal-install/tests/UnitTests/Distribution/Client/Init/FileCreators.hs
Outdated
Show resolved
Hide resolved
4191e51
to
696291b
Compare
cabal-install/tests/UnitTests/Distribution/Client/Init/FileCreators.hs
Outdated
Show resolved
Hide resolved
696291b
to
8ed1b70
Compare
exeFlags :: InitFlags | ||
exeFlags = baseFlags { | ||
-- Create an executable only, with main living in app/Main.hs. | ||
packageType = Flag Executable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 👍
Please merge when CI is green |
cabal-install/tests/UnitTests/Distribution/Client/Init/FileCreators.hs
Outdated
Show resolved
Hide resolved
8ed1b70
to
315ed11
Compare
Alright, lets see if I can get those metadata checks to pass. It's currently not possible to run the |
Let's allow only one-two GHC versions for development tools, I guess GHC-8.8 is "safe" to use now, yet I (and CI) still use 8.6. So That said. I'm not keen to upgrade the GHC used for |
Gotcha, I got the tests passing anyways so lets leave the tools as is. Just waiting for the last checks to finish then I'll merge. |
Edit: nvm, UI was out of date, appear to have done the same thing (as expected).
|
I'll be switching
cabal init
to usePrettyField
in an upcoming PR, this will make it easier to verify that the output remains approximately the same (modulo better formatting).