Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileCreators.generateCabalFile unit tests. #6678

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

m-renaud
Copy link
Collaborator

@m-renaud m-renaud commented Apr 9, 2020

I'll be switching cabal init to use PrettyField in an upcoming PR, this will make it easier to verify that the output remains approximately the same (modulo better formatting).

@m-renaud m-renaud force-pushed the m-renaud-init-unit-tests branch 3 times, most recently from 4191e51 to 696291b Compare April 10, 2020 15:22
@m-renaud m-renaud force-pushed the m-renaud-init-unit-tests branch from 696291b to 8ed1b70 Compare April 10, 2020 16:31
exeFlags :: InitFlags
exeFlags = baseFlags {
-- Create an executable only, with main living in app/Main.hs.
packageType = Flag Executable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍

@phadej
Copy link
Collaborator

phadej commented Apr 10, 2020

Please merge when CI is green

@m-renaud m-renaud force-pushed the m-renaud-init-unit-tests branch from 8ed1b70 to 315ed11 Compare April 10, 2020 17:03
@m-renaud
Copy link
Collaborator Author

Alright, lets see if I can get those metadata checks to pass. It's currently not possible to run the make gen-extra-source-files tool, there's a base version conflict since cabal-dev-scripts.cabal has the constraints base >=4.10 && <4.13 but the rest of the packages have <4.14. Should I just bump the upper bound to <4.14 there as well?

@phadej
Copy link
Collaborator

phadej commented Apr 10, 2020

Let's allow only one-two GHC versions for development tools, I guess GHC-8.8 is "safe" to use now, yet I (and CI) still use 8.6. So base >=4.12 && <4.14.

That said. I'm not keen to upgrade the GHC used for cabal development tools too often. So we'll lag behind the "newest and shinest" GHC. I'm happy to add with-compiler: ghc-8.6.5 to cabal.project.meta.

@m-renaud
Copy link
Collaborator Author

Gotcha, I got the tests passing anyways so lets leave the tools as is. Just waiting for the last checks to finish then I'll merge.

@m-renaud m-renaud merged commit 15bcd65 into haskell:master Apr 10, 2020
@m-renaud
Copy link
Collaborator Author

m-renaud commented Apr 10, 2020

Edit: nvm, UI was out of date, appear to have done the same thing (as expected).

Hmmmmmmmm, it appears that "Merge" on the official GitHub mobile app does not do the same thing as "Merge" from the web interface 😕 Seems to not have created a merge commit for the PR, bizarre, guess I won't be doing that again.

@m-renaud m-renaud deleted the m-renaud-init-unit-tests branch April 10, 2020 20:22
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants